🌱 speedup slowest e2e tests #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensorflow/tensorflow is huge, and this causes the test to take forever. locally this reduces the test time from 17 to 2.4 seconds Signed-off-by: Spencer Schrock <[email protected]>
previously this test took 27 seconds locally, and now takes 8. which is split across 3 subtests: good repos: 1s bad repos: 5s code review policies: 2s Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
===========================================
- Coverage 76.13% 65.56% -10.57%
===========================================
Files 206 206
Lines 14053 14053
===========================================
- Hits 10699 9214 -1485
- Misses 2726 4332 +1606
+ Partials 628 507 -121 |
|
The speedups based on this PR should hopefully save 1-2 minutes total for the integration tests. The overall test time has a lot of variation between 6-10 minutes, but there's usually more stability in the individual test time. Before: After: |
raghavkaul
approved these changes
Nov 9, 2023
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
diogoteles08
pushed a commit
to diogoteles08/scorecard
that referenced
this pull request
Nov 13, 2023
* switch ossfuzz test to smaller repo tensorflow/tensorflow is huge, and this causes the test to take forever. locally this reduces the test time from 17 to 2.4 seconds Signed-off-by: Spencer Schrock <[email protected]> * reuse scorecard results for scorecard attestor policies previously this test took 27 seconds locally, and now takes 8. which is split across 3 subtests: good repos: 1s bad repos: 5s code review policies: 2s Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* switch ossfuzz test to smaller repo tensorflow/tensorflow is huge, and this causes the test to take forever. locally this reduces the test time from 17 to 2.4 seconds Signed-off-by: Spencer Schrock <[email protected]> * reuse scorecard results for scorecard attestor policies previously this test took 27 seconds locally, and now takes 8. which is split across 3 subtests: good repos: 1s bad repos: 5s code review policies: 2s Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
e2e test speedup
What is the current behavior?
Theres 2 tests which are 1-2 orders of magnitude slower than other e2e tests:
tensorflow/tensorflowis a really big repo and this test downloads the repo.What is the new behavior (if this is a feature change)?**
"Should return use of OSS-Fuzz"
ossf/scorecard-webappis a much smaller repo which is fuzzed by OSSFuzz"Should attest to repos based on policy"
ossf-tests/scorecard-binauthz-test-good, I changed the existing test to just test this one.ossf-tests/scorecard-binauthz-test-badandossf-tests/scorecard-attestor-code-review-e2e), I changed the tests so they only fetch the results once, and just test the various policies against it.Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)